Block Extension QSL #100
Draft
Block Extension QSL #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a property from a block with proxies, without crashing the game if the peroperty doesn't exist.
LambdAurora
reviewed
Apr 22, 2022
There was a problem hiding this comment.
Some notes:
- we use
<Class>Mixinand notMixin<Class> - I feel like copyProperty should do checks to avoid copying something that cannot be copied
- getProxyDefaultState probably should be replaced with a more generic method called
mergeStates(BlockState source, BlockState target).
Also don't forget to run the applyLicenses task!
...ry/block/block_extensions/src/main/java/org/quiltmc/qsl/block/extensions/api/QuiltBlock.java
Outdated
Show resolved
Hide resolved
.../block/block_extensions/src/main/java/org/quiltmc/qsl/block/extensions/mixin/MixinBlock.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public ActionResult onUse(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockHitResult hit) { | ||
| var prop = QuiltBlock.getProperty(state, StairsBlock.HALF); |
There was a problem hiding this comment.
This usage of getProperty doesn't sound useful?
If the stuff that was merged were merged properly, it should already include the property.
Co-authored-by: LambdAurora <[email protected]>
…ions. Sorry, I didn't know 😔 Co-authored-by: LambdAurora <[email protected]>
How would you generify I struggle to see any ways to 100% generify this method in particular, as it's currently not possible to target a single Proxy and it needs to get all of them in a loop to gather teh default states. Unless I create a new method to |
Fix Block Mixin name to fit naming conventions
Azagwen
changed the title
LambdAurora
added
library: block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the base for a QuiltBlock Utility, which currently only has Property proxying (i.e creating blocks that "extend" multiple blocks, thus inheriting their blockstate properties)
To create a block proxy, you simply call
QuiltBlock.createProxy()in its constructor, asTestBlockfor the example mod shows.QuiltBlock.createProxy()takes the block's settings, and an array of already registered blocks, the block settings are only used to be able to call the method itself, as this needs to happen at thesuper()call